-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert NSUInteger to NSInteger #440
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nothing is breaking. IMHO, we can push this one in 2.2.0. |
@rnystrom has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
jessesquires
pushed a commit
that referenced
this pull request
Jan 23, 2017
Summary: - [x] All tests pass. Demo project builds and runs. No breaking changes that I am aware of. Closes #440 Differential Revision: D4448496 Pulled By: rnystrom fbshipit-source-id: 9ad9bc3734b605ceab25bf6cdf993568aa6561c1
@jessesquires should all be internal changes |
@jessesquires There's no public API changes in this PR. |
ah right 👍 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
#431
Pull request checklist
No breaking changes that I am aware of.